Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: treat vite config files as dev files #130

Merged

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Nov 12, 2024

Description

Marks the vite / vitest config files as development files so that the import/no-extraneous-dependencies rule works properly.

Motivation and Context

Without this, eslint throws an error saying any imports they use should be added to dependencies not devDependencies.

How Has This Been Tested?

Packed and installed in a repo using vitest.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

@smackfu smackfu closed this Nov 13, 2024
@smackfu smackfu reopened this Nov 13, 2024
@10xLaCroixDrinker 10xLaCroixDrinker merged commit ef8c6ab into americanexpress:main Nov 15, 2024
8 checks passed
oneamexbot added a commit that referenced this pull request Nov 15, 2024
# [16.3.0](v16.2.0...v16.3.0) (2024-11-15)

### Features

* treat vite config files as dev files ([#130](#130)) ([ef8c6ab](ef8c6ab))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 16.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants