[chandas] Add support for yati #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should resolve ambuda-org#97 1. Added pAdAnta yati in the meters.tsv data 2. The yati information is stored in each pada as offset numbers according to how suggested by @akprasad
akprasad
requested changes
Jan 1, 2024
vidyut-chandas/src/vrtta.rs
Outdated
| @@ -91,22 +94,39 @@ fn to_counts(text: &str) -> Vec<usize> { | |||
| .collect() | |||
| } | |||
|
|
|||
| /// Models a *feet/leg* of a verse, which constitutes of a specific pattern of light and heavy syllables along with some additional information like the yati positions. | |||
There was a problem hiding this comment.
Perhaps:
/// Models a *pāda*, which is one of the four "feet" or "legs" of a verse. A *pāda* defines a specific pattern of light and heavy syllables and might also define one or more *yati*s (caesuras).
Make sure to wrap text as well.
The non-trivial Changes: 1. `to_weights` is now a TryFrom trait 2. Removed the `weights_as_vector` method 3. Removed the yati at the end of each pada from the data.
|
Code LGTM, but it looks like some lints are failing. Once those are resolved, let's merge it in! |
|
Formatted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #97