-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SARIT, add स्कन्दपुराणम् #89
Draft
epicfaace
wants to merge
10
commits into
ambuda-org:main
Choose a base branch
from
epicfaace:sarit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
epicfaace
commented
Aug 7, 2022
•
edited
Loading
edited
- Add sarit.py to import from SARIT
- Make gretil.py more generic so its functions can be reused by sarit parsing code. In a future PR, I will move these functions to a "tei_utils.py" file.
- Add स्कन्दपुराणम् from SARIT
So far so good! As part of the test plan, let's make sure the original gretil script still works. |
epicfaace
changed the title
Support SARIT, add स्कन्दपुराण
Support SARIT, add स्कन्दपुराणम्
Aug 12, 2022
@akprasad should be ready for review now, and GRETIL import still works. |
Actually, there are two issues with skandapuranam:
|
Forgive the late follow-up. At a minimum, any verse/paragraph we display should have an xml:id defined, as this is how we cross-link translations, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.