Re-add CSP, use flask-talisman #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
epicfaace
commented
Aug 25, 2022
epicfaace
commented
- Re-add CSP, set unsafe-inline for CSS and unsafe-eval for JS to ensure the proofer functionality still works
- Use flask-talisman to set CSP. This also sets a bunch of other best-practice security defaults like HSTS, etc. -- see https://github.com/GoogleCloudPlatform/flask-talisman
epicfaace
commented
Aug 25, 2022
|
Just to check, have you already looked through the docs here? |
Yes, I tried this, though 1) alpinejs-csp is not available through the cdn and you need to bundle it locally, and 2) when I did that, and did what the docs suggested around |
|
Cool, overall SGTM. Before merge, let's resolve the outstanding conflicts. I also removed the |
akprasad
reviewed
Sep 9, 2022
ambuda/static/js/main.js
Outdated
| @@ -8,6 +8,7 @@ import Reader from './reader'; | |||
| import Proofer from './proofer'; | |||
| import HamburgerButton from './hamburger-button'; | |||
| import ProofingCreatePoll from './proofing-create-poll'; | |||
| import SortableList from './sortable-list'; | |||
There was a problem hiding this comment.
oh, maybe my diff was out of date? lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.