Features/fix ci #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitmq defaults 3.8 changed in last 6 years. Seems one exchange disapeared. Signed-off-by: Justin Cinkelj <[email protected]>
Signed-off-by: Justin Cinkelj <[email protected]>
It was not compatible with older python versions. Signed-off-by: Justin Cinkelj <[email protected]>
Signed-off-by: Justin Cinkelj <[email protected]>
justinc1
force-pushed
the
features/fix-ci
branch
2 times, most recently
from
c8cfd07 to
e50f564
Compare
Signed-off-by: Justin Cinkelj <[email protected]>
justinc1
force-pushed
the
features/fix-ci
branch
from
e50f564 to
0da29c4
Compare
Old vs new URL: old http://172.17.0.3:15672/api/channels/172.17.0.1%3A53634+-%3E+172.17.0.3%3A5672+%281%29/ new http://172.17.0.3:15672/api/channels/172.17.0.1%3A53634%20-%3E%20172.17.0.3%3A5672%20%281%29/ Signed-off-by: Justin Cinkelj <[email protected]>
omoumniabdou
pushed a commit
to optimdata/rabbitmq-admin
that referenced
this pull request
Oct 22, 2021
* Black * Fix tests as in ambitioninc#7 * Add env variables for tests
omoumniabdou
pushed a commit
to optimdata/rabbitmq-admin
that referenced
this pull request
Oct 22, 2021
* Add CRUD on topic-permissions * Black * Fix tests as in ambitioninc#7 * Add env variables for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current master fails CI tests. The PR fixes this.
I believe also #6 should pass majority of tests if this is accepted. See https://travis-ci.org/github/ambitioninc/rabbitmq-admin/jobs/727879834 - it complains about 8 vs. 9 exchanges, and about 0 vs. 1 connection.