Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom index.d.ts file to support typescript projects #230

Merged
merged 1 commit into from
Aug 12, 2024
Merged

add custom index.d.ts file to support typescript projects #230

merged 1 commit into from
Aug 12, 2024

Conversation

mhiaror
Copy link
Collaborator

@mhiaror mhiaror commented Aug 9, 2024

Issue #, if available:
Typings auto-generated using tsc are not useful, adding custom typings file index.d.ts

Description of changes:

  • add custom index.d.ts file to support typescript projects

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mhiaror mhiaror requested a review from a team as a code owner August 9, 2024 23:35
@mhiaror mhiaror requested review from psravankumarreddy and sainapra and removed request for a team August 9, 2024 23:35
haomingli2020
haomingli2020 reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@haomingli2020 haomingli2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since the index.d.ts file is manually written. How did you confirm the types are correct?
  2. Is there a way to write unit tests to confirm the index.d.ts compiles correctly on every build?

package.json Outdated Show resolved Hide resolved
@mrajatttt mrajatttt self-requested a review August 12, 2024 19:38
@mhiaror mhiaror merged commit f23564f into amazon-connect:master Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrajatttt mrajatttt mrajatttt approved these changes

@haomingli2020 haomingli2020 haomingli2020 approved these changes

@psravankumarreddy psravankumarreddy Awaiting requested review from psravankumarreddy psravankumarreddy is a code owner automatically assigned from amazon-connect/blitz

@sainapra sainapra Awaiting requested review from sainapra sainapra is a code owner automatically assigned from amazon-connect/blitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhiaror @haomingli2020 @mrajatttt