Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing error loggin caused by ChatJS #226

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fixing error loggin caused by ChatJS #226

merged 2 commits into from
Jul 23, 2024

Conversation

mrajatttt
Copy link
Collaborator

Issue #, if available:

Description of changes:

  • prevent overridding connect global namespace when ChatJS is initialized

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mrajatttt mrajatttt requested a review from a team as a code owner July 23, 2024 03:22
@mrajatttt mrajatttt requested review from jagadeeshaby, doreechi, mhiaror and mliao95 and removed request for a team, jagadeeshaby and doreechi July 23, 2024 03:22
@mrajatttt mrajatttt changed the title fixing Streams SDK bug caused by ChatJS fixing error loggin caused by ChatJS Jul 23, 2024
Copy link
Collaborator

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try syncing all of ChatJS

@mrajatttt mrajatttt merged commit 7d8f032 into master Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants