expose deep heart beat callbacks to clients #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrajatttt
requested review from
doreechi and
spenlep-amzn
and removed request for
a team
spenlep-amzn
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Should we add anything to the README [example]?
chatSession.onDeepHeartbeatSuccess()
| ### Fixed | ||
| - .onConnectionEstablished() is fired twice after invoking .connect(); closes #124 | ||
| - enable message receipts by default; closes #132 | ||
| - expose deep heartbeat success/failure callback to clients |
There was a problem hiding this comment.
I fixed the npm vulnerabilities in #212 could we merge that one instead
doreechi
approved these changes
Mar 6, 2024
spenlep-amzn
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.