Skip to content

Commit

Permalink
Improved: trigger id for the search-modal and reverted console statem…
Browse files Browse the repository at this point in the history
…ent (hotwax#301)
  • Loading branch information
amansinghbais committed Jul 9, 2024
1 parent 396779a commit 6d7403a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/components/DxpGitBookSearch.vue
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<template>
<ion-tab-button tab="help" id="time-zone-modal">
<ion-tab-button tab="help" id="gibook-search-modal">
<ion-icon :icon="helpOutline" />
<ion-label>{{ translate("Help") }}</ion-label>
</ion-tab-button>

<!-- Using inline modal(as recommended by ionic), also using it inline as the component inside modal is not getting mounted when using modalController -->
<ion-modal ref="gitBookSearchModal" trigger="time-zone-modal">
<ion-modal ref="gitBookSearchModal" trigger="gibook-search-modal">
<ion-header>
<ion-toolbar>
<ion-buttons slot="start">
Expand Down Expand Up @@ -205,7 +205,6 @@ async function searchQuery() {
let items = [] as any;
const baseURL = process.env.VUE_APP_GITBOOK_BASE_URL
console.log(baseURL);
try {
const resp = await gitBookContext.searchQuery({
Expand Down

0 comments on commit 6d7403a

Please sign in to comment.