fixed g431 build #134
Merged
fixed g431 build #134
+505
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was reverted inadvertently as part of the eeprom restructure PR
this was for the old Makefile build, and is not used at all
AlkaMotors
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The g431 build was missing the gcc specific startup file, I had it locally when I tested but forgot to add back when I added g431 makefile support. Unfortunately the compiler only throws a warning when Reset_Handler is missing at the link stage, not an error, so it didn't show up in CI testing
I also had to fix the linker script for g431 to have more space in the FLASH_VECTAB region as it overflowed, and while fixing that I had to remove the FLASH_VERSION section, which is unused. The old USE_MAKE code in main used firmware_info which used this section, but that isn't used any more since we went to the new Makefile system. The USE_MAKE changes had been resurrected by a bad rebase of the eeprom PR.
To clean things up this PR removes all of the FLASH_VERSION sections in the linker script, which are unused.