perf: Loading state and double renders (BAN-15) #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a loading state in the Match Voucher tab when the matching vouchers take time to arrive - Add a loading state for the transaction summary above the table, which should just be 0 values - fix: Avoid calling `populate_matching_vouchers` twice on changing the match tab filters
marination
changed the title
barredterra
reviewed
Oct 16, 2024
banking/public/js/bank_reconciliation_beta/actions_panel/match_tab.js
Outdated
Show resolved
Hide resolved
refactor: show frozen datatable while loading
|
@Mergifyio backport version-14 |
❌ No backport have been created
Git reported the following error: |
marination
added a commit
that referenced
this pull request
Oct 28, 2024
fix: Loading state and double renders (BAN-15) (bp #112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populate_matching_voucherstwice on changing the match tab filters