[WIP] Seek using thumbnails #1
Conversation
…but there is a major bug (possibly) because of the GDI cache. It's hackish as well.
|
The GDI cache changes over time and entries get set/unset/replaced as the server sees fit. ideally we would record the cache (and its transitions) as part of the pyrdp session file format. This is currently not the case and will require a new format for binary sessions. If we're going to make improvements to the file format, it would be worth it to tackle a few other things such as embedded bitmaps. We can focus on getting improved seek working on bitmap streams first, and improve it eventually. the code should be generic anyway. |
| first_thumbnail_timestamp = timestamp | ||
| thumbnails[timestamp - first_thumbnail_timestamp] = ( | ||
| f"{thumbnail_directory}/{file}", | ||
| f"{thumbnail_directory}/gdi_cache/{file}".replace('.png', '.bitmapcache')) |
There was a problem hiding this comment.
I don't think saving a snapshot of the cache at every frame is going to be enough. on large enough intervals, the cache might change several times in-between two thumbnails.
There was a problem hiding this comment.
Yeah, but if I save the cache at the time of the thumbnail, and i replay events starting at the thumbnail, shoulnt the cache get updated correctly then? Or the player doesnt update the cache when playing the replay?
|
So you suggest I remove the part where the cache is saved to disk? |
It works, but there are noticable glitches (possibly) because of the GDI cache. I tried to save GDI's bitmap cache to disk and set it, but it doesnt seem to fix the issue. I'd appreciate your input on this, I looked for a while and I thought the logic was good, but clearly I missed something.