Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTV-469 Add new method GetHwidProtHash #159

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

ALTV-469 Add new method GetHwidProtHash #159

wants to merge 5 commits into from

Conversation

OlegTrofimov
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing generated hashes

@@ -246,6 +246,10 @@ uint64_t Player_GetHwidExHash(alt::IPlayer* player) {
return player->GetHwidExHash();
}

std::string Player_GetHwidProtHash(alt::IPlayer* player) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing size paramter

@@ -246,6 +246,10 @@ uint64_t Player_GetHwidExHash(alt::IPlayer* player) {
return player->GetHwidExHash();
}

std::string Player_GetHwidProtHash(alt::IPlayer* player) {
return player->GetHwidProtHash();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing call AllocateString

@@ -77,6 +77,7 @@ EXPORT_SERVER void Player_SetModel(alt::IPlayer* player, uint32_t model);
EXPORT_SERVER uint64_t Player_GetSocialID(alt::IPlayer* player);
EXPORT_SERVER uint64_t Player_GetHwidHash(alt::IPlayer* player);
EXPORT_SERVER uint64_t Player_GetHwidExHash(alt::IPlayer* player);
EXPORT_SERVER const char* Player_GetHwidProtHash(alt::IPlayer* player);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing size paramter

@@ -22,6 +22,7 @@ EXPORT_SERVER uint64_t ConnectionInfo_GetSocialId(alt::IConnectionInfo* connecti
EXPORT_SERVER const char* ConnectionInfo_GetSocialName(alt::IConnectionInfo* connectionInfo, int32_t& size);
EXPORT_SERVER uint64_t ConnectionInfo_GetHwIdHash(alt::IConnectionInfo* connectionInfo);
EXPORT_SERVER uint64_t ConnectionInfo_GetHwIdExHash(alt::IConnectionInfo* connectionInfo);
EXPORT_SERVER const char* ConnectionInfo_GetHwIdProtHash(alt::IConnectionInfo* connectionInfo);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing size parameter

@@ -37,6 +37,10 @@ uint64_t ConnectionInfo_GetHwIdExHash(alt::IConnectionInfo* connectionInfo) {
return connectionInfo->GetHwIdExHash();
}

std::string ConnectionInfo_GetHwIdProtHash(alt::IConnectionInfo* connectionInfo) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing size parameter

@@ -37,6 +37,10 @@ uint64_t ConnectionInfo_GetHwIdExHash(alt::IConnectionInfo* connectionInfo) {
return connectionInfo->GetHwIdExHash();
}

std::string ConnectionInfo_GetHwIdProtHash(alt::IConnectionInfo* connectionInfo) {
return connectionInfo->GetHwIdProtHash();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing AllocateString

@@ -327,6 +328,9 @@ namespace cache
return _hwidExHash;
}

std::string _hwidPtorHash;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants