Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dotnet8 #157

Merged
merged 6 commits into from
Sep 30, 2024
+2 −2
Merged

Feat/dotnet8 #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57b2f39
chore: bump to dotnet8
Doxoh Mar 26, 2024
a4d32b0
fix(client): load correct dotnet version
Doxoh Mar 26, 2024
92e84ac
fix(client): fix some errors for downloading required files
Doxoh Apr 3, 2024
b1ec037
Merge branch 'dev' into feat/dotnet8
Doxoh Aug 23, 2024
c99af68
Merge branch 'dev' into feat/dotnet8
Doxoh Sep 24, 2024
bfb69d3
Merge branch 'dev' into feat/dotnet8
Doxoh Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/coreclr/CoreClr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ uint8_t GetCachedAssembly(const char* name, int* bufferSize, void** buffer) {
auto stream = std::ifstream(path, std::ios::binary);
miniz_cpp::zip_file zip(stream);
std::stringstream contentStream;
auto fileName = std::string("lib/net6.0/") + name + ".dll";
auto fileName = std::string("lib/net8.0/") + name + ".dll";
if (!zip.has_file(fileName)) {
cs::Log::Warning << "Nupkg was found, but no dll was found in it " << fileName << cs::Log::Endl;
zip.printdir();
Expand Down
2 changes: 1 addition & 1 deletion download_dotnet.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ $start = $pwd

cd $path

$dotnetRelease = Invoke-WebRequest 'https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/6.0/releases.json' | ConvertFrom-Json
$dotnetRelease = Invoke-WebRequest 'https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/8.0/releases.json' | ConvertFrom-Json

$dotnetVersion = $dotnetRelease."latest-release"

Expand Down
Loading