Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared: Add alt.off function reference validation #234

Merged
merged 2 commits into from
Dec 27, 2022
Merged

shared: Add alt.off function reference validation #234

merged 2 commits into from
Dec 27, 2022

Conversation

xxshady
Copy link
Contributor

@xxshady xxshady commented Dec 4, 2022

Closes #229

@xxshady xxshady requested a review from LeonMrBonnie as a code owner December 4, 2022 17:45
LeonMrBonnie
LeonMrBonnie approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@LeonMrBonnie LeonMrBonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't really fix the underlying issue but fuck it

@xxshady
Copy link
Contributor Author

xxshady commented Dec 4, 2022

CgACAgQAAxkBAAFPYvtjjOdmTtARe5_rI7BEEOm7AspxagAC4AIAAm3mDFMpExhEyLAo6ysE_1670178710 88

@xxshady
Copy link
Contributor Author

xxshady commented Dec 19, 2022

@LeonMrBonnie what fait awaits this PR?

@LeonMrBonnie
Copy link
Contributor

was too lazy to press merge

@LeonMrBonnie LeonMrBonnie merged commit b385b7e into altmp:dev Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMrBonnie LeonMrBonnie LeonMrBonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling alt.off with invalid function reference breaks other listeners
2 participants
@xxshady @LeonMrBonnie