Add OpenAI Embeddings Primitive #251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a primitive for natural language logical types that uses the OpenAI Embeddings API to calculate embeddings features. The model to use is configurable, but text-embedding-ada-002 is used by default.
|
|
sbadithe
reviewed
Mar 10, 2023
sbadithe
reviewed
Mar 10, 2023
|
|
||
| def can_fit_in_batch(tokens) -> bool: | ||
| return ( | ||
| len(elements_in_batch) < 2048 |
There was a problem hiding this comment.
Is 2048 the maximum number of elements per batch?
There was a problem hiding this comment.
yeah, here's the limit in the openai client: https://github.com/openai/openai-python/blob/main/openai/embeddings_utils.py#L43
sbadithe
reviewed
Mar 10, 2023
sbadithe
reviewed
Mar 10, 2023
|
|
||
| # can this element fit in the batch? | ||
| if can_fit_in_batch(next_tokens): | ||
| # can't fit -- construct a request with existing elements |
There was a problem hiding this comment.
Not sure if I am misunderstanding this, but does this block cover the case where it can fit?
There was a problem hiding this comment.
Good call. Fixed. I need to add tests for all of this to catch stuff like this 😅
Co-authored-by: Shripad Badithe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a primitive for natural language logical types that uses the OpenAI Embeddings API to calculate embeddings features.
The model to use is configurable, but
text-embedding-ada-002is used by default.