Draft: testing how long prophet test take without pytest-xdist #4438
Conversation
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4438 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 352 352
Lines 39804 40035 +231
=======================================
+ Hits 39683 39914 +231
Misses 121 121 ☔ View full report in Codecov by Sentry. |
| command: 'git-test-other' | ||
| - python_version: "3.9" | ||
| command: 'git-test-parallel' | ||
| python_version: ['3.9'] |
There was a problem hiding this comment.
Should we also be running tests with 3.10 and 3.11 here?
There was a problem hiding this comment.
Looks like adding 3.11 test fails unit git-test-automl tests (pull_request).
I'm tempted to just add 3.10 for now, and file a ticket to add 3.11, but I'll look to see if it's a quick fix.
| automl.results = 2.0 | ||
|
|
||
| assert "set attribute" in str(atr_error.value) or "has no setter" in str( | ||
| atr_error.value, | ||
| ) |
There was a problem hiding this comment.
So the python3.11 test errors without this change. I can't find why, but it changes the text of the AttributeError raises here to property 'results' of 'AutoMLSearch' object has no setter rather than before, which was can't set attribute.
Also codecov said that this line isn't covered, but in the full report it says it's fine.
|
Pushed this branch into #4436. Closing this one. |
Pull Request Description
read title
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.