Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MASE error by passing through y_train #4258

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Fix MASE error by passing through y_train #4258

merged 5 commits into from
Aug 4, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Aug 3, 2023

Closes #4257

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4258 (1b06f51) into main (30f3242) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4258     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        351     351             
  Lines      38497   38512     +15     
=======================================
+ Hits       38376   38391     +15     
  Misses       121     121             
Files Changed Coverage Δ
...valml/pipelines/time_series_regression_pipeline.py 100.0% <ø> (ø)
evalml/pipelines/binary_classification_pipeline.py 100.0% <100.0%> (ø)
evalml/pipelines/pipeline_base.py 98.5% <100.0%> (ø)
.../pipelines/time_series_classification_pipelines.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <100.0%> (+0.1%) ⬆️

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccabay eccabay merged commit 045686d into main Aug 4, 2023
@eccabay eccabay deleted the 4257_mase_ytrain branch August 4, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MASE requires y_train
3 participants