Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Update targetLeakageDataCheck to handle boolean values #4061

Closed
wants to merge 4 commits into from

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Mar 9, 2023

Fixes: #4062. This MR relies on this Woodwork PR in order to work properly. There is a bug that exists that the mentioned PR addresses.

@bchen1116 bchen1116 self-assigned this Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #4061 (5996b78) into main (f509df4) will decrease coverage by 29.6%.
The diff coverage is 50.0%.

@@           Coverage Diff            @@
##            main   #4061      +/-   ##
========================================
- Coverage   99.7%   70.0%   -29.6%     
========================================
  Files        349     349              
  Lines      37509   37507       -2     
========================================
- Hits       37391   26251   -11140     
- Misses       118   11256   +11138     
Impacted Files Coverage Δ
...ata_checks_tests/test_target_leakage_data_check.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/data_checks/target_leakage_data_check.py 75.7% <100.0%> (-19.3%) ⬇️

... and 175 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bchen1116
Copy link
Contributor Author

Closing because work is being done here

@bchen1116 bchen1116 closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update targetLeakageDataCheck to handle boolean targets
1 participant