Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo env checkmates refactoring #19

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

NabilFayak
Copy link
Collaborator

  • Added modules necessary to remove EvalML dependencies within tempo testing environment

Resolves #18

@Cmancuso
Copy link
Contributor

This is all duplicated from EvalML right? Is all of this strictly dependency? I believe much of this is foundational for EvalML as well right?

@NabilFayak
Copy link
Collaborator Author

This is all duplicated from EvalML right? Is all of this strictly dependency? I believe much of this is foundational for EvalML as well right?

All of the modules added here are to resolve the EvalML dependencies found within the tempojobs datachecks testing portion. Specifically, the data_check and data_check_actions files within tempojobs. None of the modules added are required by CheckMates, so they could be foundational to EvalML, but they aren't important to CheckMates. Once implemented, we can isolate the testing within tempo, as the last test showed zero improvement due to the extraneous EvalML usage within the files mentioned.

@NabilFayak NabilFayak merged commit dc8dfe9 into main Aug 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TempoJobs testing environment still uses EvalML dependencies
4 participants