Tests + renaming variables

alterphp · Mar 31, 2018 · e2a056e · e2a056e
1 parent e9ac26d
commit e2a056e
Show file tree

Hide file tree

Showing 8 changed files with 80 additions and 13 deletions.
diff --git a/src/Configuration/EmbeddedListViewConfigPass.php b/src/Configuration/EmbeddedListViewConfigPass.php
@@ -10,17 +10,17 @@
  */
 class EmbeddedListViewConfigPass implements ConfigPassInterface
 {
-    private $defaultOpenInNewTabLink;
+    private $defaultOpenNewTab;
 
-    public function __construct($defaultOpenInNewTabLink)
+    public function __construct($defaultOpenNewTab)
     {
-        $this->defaultOpenInNewTabLink = $defaultOpenInNewTabLink;
+        $this->defaultOpenNewTab = $defaultOpenNewTab;
     }
 
     public function process(array $backendConfig)
     {
         $backendConfig = $this->processSortingConfig($backendConfig);
-        $backendConfig = $this->processOpenInNewTabLinkConfig($backendConfig);
+        $backendConfig = $this->processOpenNewTabConfig($backendConfig);
 
         return $backendConfig;
     }
@@ -30,11 +30,11 @@ public function process(array $backendConfig)
      *
      * @return array
      */
-    private function processOpenInNewTabLinkConfig(array $backendConfig)
+    private function processOpenNewTabConfig(array $backendConfig)
     {
         foreach ($backendConfig['entities'] as $entityName => $entityConfig) {
-            if (!isset($entityConfig['embeddedList']['open_in_new_tab_link'])) {
-                $backendConfig['entities'][$entityName]['embeddedList']['open_in_new_tab_link'] = $this->defaultOpenInNewTabLink;
+            if (!isset($entityConfig['embeddedList']['open_new_tab'])) {
+                $backendConfig['entities'][$entityName]['embeddedList']['open_new_tab'] = $this->defaultOpenNewTab;
             }
         }
 

diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -39,7 +39,7 @@ public function getConfigTreeBuilder()
                 ->arrayNode('embedded_list')
                     ->addDefaultsIfNotSet()
                     ->children()
-                        ->booleanNode('open_in_new_tab_link')
+                        ->booleanNode('open_new_tab')
                             ->defaultTrue()
                         ->end()
                     ->end()

diff --git a/src/DependencyInjection/EasyAdminExtensionExtension.php b/src/DependencyInjection/EasyAdminExtensionExtension.php
@@ -25,8 +25,8 @@ public function load(array $configs, ContainerBuilder $container)
         $container->setParameter('easy_admin_extension.custom_form_types', $config['custom_form_types']);
         $container->setParameter('easy_admin_extension.minimum_role', $config['minimum_role']);
         $container->setParameter(
-            'easy_admin_extension.embedded_list.open_in_new_tab_link',
-            $config['embedded_list']['open_in_new_tab_link']
+            'easy_admin_extension.embedded_list.open_new_tab',
+            $config['embedded_list']['open_new_tab']
         );
 
         $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -13,7 +13,7 @@
             <tag name="easyadmin.config_pass" priority="41"/>
         </service>
         <service id="alterphp.easyadmin_extension.config_pass.embedded_list_view" class="AlterPHP\EasyAdminExtensionBundle\Configuration\EmbeddedListViewConfigPass">
-            <argument>%easy_admin_extension.embedded_list.open_in_new_tab_link%</argument>
+            <argument>%easy_admin_extension.embedded_list.open_new_tab%</argument>
             <!-- Makes it process just after ViewConfigPass -->
             <tag name="easyadmin.config_pass" priority="29"/>
         </service>

diff --git a/src/Resources/views/default/embedded_list.html.twig b/src/Resources/views/default/embedded_list.html.twig
@@ -98,12 +98,12 @@
             {% endblock table_body %}
             </tbody>
 
-            {% if _entity_config.embeddedList.open_in_new_tab_link %}
+            {% if _entity_config.embeddedList.open_new_tab %}
             <tfoot>
               <tr>
                 <td colspan="{{ _columns_count }}" class="text-center">
                   {% block open_new_tab %}
-                  <a class="btn btn-info btn-xs" title="{{ 'open.new_tab'|trans({}, 'EasyAdminBundle') }}" target="_blank" href="{{ path('easyadmin', _request_parameters|merge({action: 'list'})) }}">
+                  <a class="btn btn-info btn-xs open-new-tab" title="{{ 'open.new_tab'|trans({}, 'EasyAdminBundle') }}" target="_blank" href="{{ path('easyadmin', _request_parameters|merge({action: 'list'})) }}">
                     <i class="fa fa-external-link-square"></i>
                     <span>{{ 'open.new_tab'|trans({}, 'EasyAdminBundle') }}</span>
                   </a>

diff --git a/tests/Configuration/EmbeddedListViewConfigPassTest.php b/tests/Configuration/EmbeddedListViewConfigPassTest.php
@@ -0,0 +1,50 @@
+<?php
+
+namespace AlterPHP\EasyAdminExtensionBundle\Tests\Configuration;
+
+use AlterPHP\EasyAdminExtensionBundle\Configuration\EmbeddedListViewConfigPass;
+
+class EmbeddedListViewConfigPassTest extends \PHPUnit_Framework_TestCase
+{
+    public function testOpenNewTabOption()
+    {
+        $embeddedListViewConfigPass = new EmbeddedListViewConfigPass(true);
+
+        $backendConfig = array(
+            'entities' => array(
+                'NotSetEntity' => array(
+                ),
+                'SetTrueEntity' => array(
+                    'embeddedList' => array('open_new_tab' => true)
+                ),
+                'SetFalseEntity' => array(
+                    'embeddedList' => array('open_new_tab' => false)
+                ),
+            ),
+        );
+
+        $backendConfig = $embeddedListViewConfigPass->process($backendConfig);
+
+        $expectedBackendConfig = array(
+            'entities' => array(
+                'NotSetEntity' => array(
+                    'embeddedList' => array(
+                        'open_new_tab' => true,
+                    ),
+                ),
+                'SetTrueEntity' => array(
+                    'embeddedList' => array(
+                        'open_new_tab' => true,
+                    ),
+                ),
+                'SetFalseEntity' => array(
+                    'embeddedList' => array(
+                        'open_new_tab' => false,
+                    ),
+                ),
+            ),
+        );
+
+        $this->assertSame($backendConfig, $expectedBackendConfig);
+    }
+}
diff --git a/tests/Controller/EmbeddedListTest.php b/tests/Controller/EmbeddedListTest.php
@@ -138,4 +138,18 @@ public function testDefinedSortIsUsedForEmbedddLists()
 
         $this->assertSame(1, $crawler->filter('.embedded-list[for="'.$forAttrValue.'"] '.$createdAtTh)->count());
     }
+
+    public function testDefaultOpenNewTabConfigForEmbedddLists()
+    {
+        $crawler = $this->getBackendPage(array('entity' => 'Product', 'action' => 'embeddedList'));
+
+        $this->assertSame(0, $crawler->filter('.embedded-list .open-new-tab')->count());
+    }
+
+    public function testSetOpenNewTabConfigForEmbedddLists()
+    {
+        $crawler = $this->getBackendPage(array('entity' => 'Purchase', 'action' => 'embeddedList'));
+
+        $this->assertSame(1, $crawler->filter('.embedded-list .open-new-tab')->count());
+    }
 }
diff --git a/tests/Fixtures/App/config/config_embedded_list.yml b/tests/Fixtures/App/config/config_embedded_list.yml
@@ -4,6 +4,8 @@ imports:
 easy_admin_extension:
     custom_form_types:
         embedded_list: AlterPHP\EasyAdminExtensionBundle\Form\Type\EasyAdminEmbeddedListType
+    embedded_list:
+        open_new_tab: false
 
 easy_admin:
     entities:
@@ -20,4 +22,5 @@ easy_admin:
         Purchase:
             class: AppTestBundle\Entity\FunctionalTests\Purchase
             embeddedList:
+                open_new_tab: true
                 sort: [createdAt, DESC]