Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented axe accessibility changes for about + blog #2169

Closed
wants to merge 5 commits into from

Conversation

brielle5810
Copy link

@brielle5810 brielle5810 commented Feb 7, 2024

aria-labels in relevant links
"landmark-banner-is-top-level" violation in about changed
change of bullet points from paragraphs to list items
discernible text/color contrast violations fixed
For issue #2087

aria labels added to links
legible text color (constrast)
color contrast--legibility
aria-labels added to links
@george-gca
Copy link
Collaborator

@brielle5810 thanks for the hard work. I would love for you to give me some explanation about these changes, so that I can understand how these work. For example, I saw that you added a body tag to _layouts/about.liquid, but this page uses layout: default internally, which already has a body tag, so how does this work?

I saw that the font is a little darker, I figured that some color changes was needed. The only thing is that in the blog page dark version, the Newer word is barely readable.

image

Copy link

stale bot commented Apr 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 18, 2024
@stale stale bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants