Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandoc "--no-wrap" option detection #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YorkZ
Copy link

@YorkZ YorkZ commented Dec 7, 2022

The option --no-wrap has removed in pandoc v2.19.2, and therefore the output of running pandoc --no-wrap is not --no-wrap is deprecated, but --no-wrap has been removed. This fix detects both error messages to determine whether the option should be --no-wrap or --wrap=none.

@alphapapa
Copy link
Owner

Hi York,

Thanks. Would you mind using rx syntax there, to avoid the backslashes? Then this can be merged.

@YorkZ
Copy link
Author

YorkZ commented Dec 9, 2022

Hi @alphapapa,

Yes, rx is fantastic, and I've changed the PR to use rx. Thanks for reminding.

org-protocol-capture-html.el Outdated Show resolved Hide resolved
The option "--no-wrap" has removed in pandoc v2.19.2, and therefore the output
of running "pandoc --no-wrap" is not "--no-wrap is deprecated", but "--no-wrap
has been removed". This fix detects both error messages to determine whether the
option should be "--no-wrap" or "--wrap=none".
@YorkZ
Copy link
Author

YorkZ commented Dec 10, 2022

Thanks @alphapapa for pointing out, and the good suggestion.

@YorkZ YorkZ requested a review from alphapapa December 13, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants