Upgrade app to Rails 7.2 #1536
Merged
Upgrade app to Rails 7.2 #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuriloDalRi
force-pushed
the
rails-7-2
branch
from
230ae36 to
4cf33a1
Compare
AgaDufrat
approved these changes
Nov 26, 2024
config/environments/development.rb
Outdated
| config.action_mailer.perform_caching = false | ||
|
|
||
| config.action_mailer.default_url_options = { host: "localhost", port: 3000 } |
There was a problem hiding this comment.
I think we tend to use Plek for those. Surprised it didn't suggest updating those in other environments.
There was a problem hiding this comment.
I reckon we can probably remove this line
This updates the configuration files to be compatible with Rails 7.2.
MuriloDalRi
force-pushed
the
rails-7-2
branch
from
4cf33a1 to
385ded5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Rails from 7.1 to 7.2
alphagov/govuk-infrastructure#1444