Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force autoload of lib for Zeitwerk #6990

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Force autoload of lib for Zeitwerk #6990

merged 1 commit into from
Dec 6, 2024

Conversation

Tetrino
Copy link
Contributor

@Tetrino Tetrino commented Dec 6, 2024

Zeitwerk requries lib to be autoloaded early so it can be properly initialised. Previously this had been set to eager-load erroneously.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Zeitwerk requries lib to be autoloaded early so it can be properly
initialised. Previously this had been set to eager-load erroneously.
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6990 December 6, 2024 08:47 Inactive
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve if this is urgent and you've tested it and it works as you expect, but a few questions:

  1. Why define this here rather than in the array on line 33?
  2. I've looked in Frontend and Whitehall for comparison and both of them use eager_load_paths. Not entirely clear why this change is needed here when it doesn't seem to be needed for other paths.

@Tetrino Tetrino merged commit d58df17 into main Dec 6, 2024
13 checks passed
@Tetrino Tetrino deleted the fix-date-autoload branch December 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants