Merge pull request #6846 from alphagov/type-module-changes

Use type=module for application.js
alphagov · Aug 15, 2024 · 037120d · 037120d
2 parents db7b169 + 23d0e89
commit 037120d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -194,7 +194,7 @@ GEM
     govuk_personalisation (0.16.0)
       plek (>= 1.9.0)
       rails (>= 6, < 8)
-    govuk_publishing_components (41.1.1)
+    govuk_publishing_components (42.0.0)
       govuk_app_config
       govuk_personalisation (>= 0.7.0)
       kramdown

diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -26,9 +26,9 @@
     <%= csrf_meta_tags %>
     <%= csp_meta_tag %>
     <%= stylesheet_link_tag "application", :media => "all" %>
-    <%= javascript_include_tag "test-dependencies" if Rails.env.test? %>
+    <%= javascript_include_tag "test-dependencies", type: "module" if Rails.env.test? %>
     <%= javascript_include_tag "es6-components", type: "module" %>
-    <%= javascript_include_tag "application", defer: true %>
+    <%= javascript_include_tag "application", defer: true, type: "module" %>
     <%= yield :head %>
     <% if content_item %>
       <%= render "govuk_publishing_components/components/meta_tags",