Improve periodic reload #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it reloads every minute regardless if a reload has occured within that minute. This is because we never set the last reload time. This also improves the responsivness by checking for a periodic reload every 5 seconds, instead of a minute (which could potentially mean a reload could take up to 2 minutes).
theseanything
force-pushed
the
fix-periodic-reload
branch
from
55014b5 to
d54fd93
Compare
MuriloDalRi
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it reloads every minute regardless if a reload has occurred within that minute. This is because we never set the last reload time. This also improves the responsiveness by checking for a periodic reload every 5 seconds, instead of a minute (which could potentially mean a reload could take up to 2 minutes).
Renamed csLastReloadTime to csLastAttemptReloadTime for clarity.
Tested in integration