Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min Go version to 1.22 and update deps. #446

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update min Go version to 1.22 and update deps. #446

merged 2 commits into from
Apr 3, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Apr 3, 2024

Use the new version format introduced in Go 1.21. This was why CodeQL wasn't working with 1.22 before: go 1.22 is not a valid version. Versions like 1.20 used to mean the initial release such as 1.20.0.

Since the version in go.mod is still a minimum version constraint, we still don't need to worry about updating the patch version there. It can just stay as .0 unless there's some exceptional reason to change it.

sengi added 2 commits April 3, 2024 11:17
Use the new version format [introduced] in Go 1.21. This was why CodeQL
wasn't working with 1.22 before: `go 1.22` is not a valid [version]
any more. Versions like `1.20` were always shorthand for the initial
release such as `1.20.0`.

Since the version in go.mod is still a minimum version constraint, we
still don't need to worry about updating the patch version there. It can
just stay as `.0` unless there's some exceptional reason to change it.

[introduced]: https://tip.golang.org/doc/go1.21#introduction
[version]: https://tip.golang.org/doc/toolchain#version
@sengi sengi requested a review from theseanything April 3, 2024 10:28
@sengi sengi merged commit 80471ed into main Apr 3, 2024
4 checks passed
@sengi sengi deleted the sengi/1.22.0 branch April 3, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants