Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-13313 Implement save credentials functionality in POST #4391

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

DomBelcher
Copy link
Contributor

WHAT

  • Implement saving of credentials to Connector on form submission

@DomBelcher DomBelcher marked this pull request as ready for review December 18, 2024 14:16
supports3ds: ['worldpay', 'stripe'].includes(gatewayAccount.paymentProvider),
disableToggle3ds: gatewayAccount.paymentProvider === 'stripe'
})
const gatewayAccount = await connectorClient.getAccountByServiceExternalIdAndAccountType(params)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it

Copy link
Collaborator

@nlsteers nlsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@DomBelcher DomBelcher merged commit 46ec670 into master Dec 18, 2024
14 checks passed
@DomBelcher DomBelcher deleted the PP-13313/save-credentials branch December 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants