Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11681 Replace ‘base-client’ with ‘axios-base-client’ in 'public-auth.client' #4186

Merged

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Feb 29, 2024

https://payments-platform.atlassian.net/browse/PP-11681

WHAT

  • Change ‘public-auth.client’ methods to use ‘axios-base-client’ library.
  • Refactor call parameters initialisation.
  • Use ‘async/await’ syntax.

HOW

All automated tests should pass without the need to be amended.
Existing functionality should remain unaffected.

- Change ‘public-auth.client’ methods to use ‘axios-base-client’ library.
- Refactor call parameters initialisation.
- Use ‘async/await’ syntax.
@JFSGDS JFSGDS marked this pull request as ready for review March 4, 2024 14:02
Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - approved

@JFSGDS JFSGDS merged commit 7bceddc into master Mar 12, 2024
10 checks passed
@JFSGDS JFSGDS deleted the PP-11681_replace_request_with_axios_public_auth_client branch March 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants