Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11681 Replace ‘base-client’ with ‘axios-base-client’ #4181

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Feb 26, 2024

https://payments-platform.atlassian.net/browse/PP-11681

WHAT

  • Change ‘products.client’ methods to use ‘axios-base-client’ library.
  • Refactor call parameters initialisation.
  • Use ‘async/await’ syntax.

HOW

All automated tests should pass without the need to be amended.
Existing functionality should remain unaffected.

@JFSGDS JFSGDS marked this pull request as ready for review February 26, 2024 12:10
@JFSGDS JFSGDS force-pushed the PP-11681_replace_request_with_axios_products_client branch 2 times, most recently from 8482885 to a2b4930 Compare February 28, 2024 11:17
- Change  ‘products.client’ methods to use ‘axios-base-client’ library.
- Refactor call parameters initialisation.
- Use ‘async/await’ syntax.
- Update 'disable' and 'delete' product pact tests to expect status code of ’204’.
@JFSGDS JFSGDS force-pushed the PP-11681_replace_request_with_axios_products_client branch from a2b4930 to 3d4f96a Compare February 28, 2024 11:21
Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JFSGDS JFSGDS merged commit 7c50406 into master Feb 28, 2024
10 checks passed
@JFSGDS JFSGDS deleted the PP-11681_replace_request_with_axios_products_client branch February 28, 2024 14:53
JFSGDS added a commit that referenced this pull request Mar 27, 2024
- Change  ‘products.client’ methods to use ‘axios-base-client’ library.
- Refactor call parameters initialisation.
- Use ‘async/await’ syntax.
- Update 'disable' and 'delete' product pact tests to expect status code of ’204’.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants