Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12167 Update joi to resolve hoek vulnerability #4173

Merged

Conversation

james-peacock-gds
Copy link
Contributor

@james-peacock-gds james-peacock-gds commented Feb 9, 2024

Context: Need to update joi version to one which does not use hoek versions before 8.5.1 because previous versions of hoek have a vulnerability

  • update to current joi version 17.12.1
  • update uses of joi as Joi.validate() function is no longer supported

Context: Need to update joi version to one which does not use hoek versions before 8.5.1 because previous versions of hoek have a vulnerability as described here:
 https://github.com/alphagov/pay-selfservice/security/dependabot/71

- update to current joi version 17.12.1
- update uses of joi as Joi.validate() function is no longer supported
@james-peacock-gds james-peacock-gds force-pushed the PP-12167-Update-Joi-to-fix-hoek-vulnerability branch from d066207 to 5f3a7b2 Compare February 9, 2024 11:17
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@james-peacock-gds james-peacock-gds merged commit 87c7cf2 into master Feb 9, 2024
10 checks passed
@james-peacock-gds james-peacock-gds deleted the PP-12167-Update-Joi-to-fix-hoek-vulnerability branch February 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants