PP-9916 Change test card number in Stripe test accounts #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ‘Mock card numbers’ template to test for ‘stripe’ account and display UK issued test card.
Update '.secrets.baseline' to include credentials for new cypress 'Pay demo/Mock cards' test.
Add Cypresss test to check 'Mock card' screen shows correct card number for non Stripe accounts.
alexbishop1
reviewed
Oct 19, 2023
| ]) | ||
| }) | ||
|
|
||
| it('should load the mock cards page and show non stripe card', () => { |
There was a problem hiding this comment.
Presumably we can have a version of this test that sets paymentProvider to stripe and checks we output the right card number for Stripe too?
There was a problem hiding this comment.
Agreed. Test to check correct card number is displayed for Stripe accounts now added. Note, unable to land directly on the Dashboard page for a Stripe account as this route returned a ‘403 Forbidden’ status. Landing on the Stripe account’s Settings page and then navigating to the Dashboard pages worked but this probably needs refactoring.
There was a problem hiding this comment.
I think it’s fine — the amount of extra code to do the navigation is not huge and it’s not worth investing too much more time into this.
Add Cypresss test to check 'Mock card' screen shows correct card number for Stripe accounts.
alexbishop1
approved these changes
Oct 20, 2023
JFSGDS
deleted the
PP-9916-change-test-card-number-in-stripe-test-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Change test card number in Stripe test accounts to UK issued test card
https://payments-platform.atlassian.net/browse/PP-9916
HOW
Update ‘Mock card numbers’ template to test for ‘stripe’ account and display UK issued test card.