PP-11594 Add ‘sandbox’ to ‘isDigitalWalletSupported’ test. #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend existing ‘isDigitalWalletsSuported’ test for ‘Stripe’ and ‘Worldpay’ accounts to include ‘sandbox’ accounts - Add feature flag ‘ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT’ as part of test condition - Add unit tests for all sandbox feature flag states
We want updates for Node 18.x but not 19.x.
BAU: Fix Dependabot Docker ignore
Bumps node from 18.17.1-alpine3.18 to 18.18.2-alpine3.18. --- updated-dependencies: - dependency-name: node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…-alpine3.18 Bump node from 18.17.1-alpine3.18 to 18.18.2-alpine3.18
Update ‘Mock card numbers’ template to test for ‘stripe’ account and display UK issued test card.
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.10 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…traverse-7.23.2 Bump @babel/traverse from 7.22.10 to 7.23.2
Update '.secrets.baseline' to include credentials for new cypress 'Pay demo/Mock cards' test.
Add Cypresss test to check 'Mock card' screen shows correct card number for non Stripe accounts.
Add Cypresss test to check 'Mock card' screen shows correct card number for Stripe accounts.
…r-in-stripe-test-accounts PP-9916 Change test card number in Stripe test accounts
* PP-7843 Stop selecting default option on permission level radios
- Extend existing ‘isDigitalWalletsSuported’ test for ‘Stripe’ and ‘Worldpay’ accounts to include ‘sandbox’ accounts - Add feature flag ‘ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT’ as part of test condition - Add unit tests for all sandbox feature flag states
….com:alphagov/pay-selfservice into PP-11594-enable-apple-gpay-for-sandbox-accts
- Remove ‘apple pay toggle with unsupported payment provider request’ test - Remove ‘google pay toggle with unsupported payment provider request' test
|
can you squash some of these commits and rebase the branch, there's a bunch of merge commits in here that don't need to be, it's hard to know which are your changes at a glance |
nlsteers
reviewed
Nov 1, 2023
Comment on lines
124
to
127
| convertedData.isDigitalWalletSupported = paymentProvider === 'worldpay' || | ||
| (paymentProvider === 'sandbox' && process.env.ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT === 'true') || | ||
| (paymentProvider === 'stripe' && process.env.ALLOW_ENABLING_DIGITAL_WALLETS_FOR_STRIPE_ACCOUNT === 'true') || | ||
| (paymentProvider === 'stripe' && convertedData.isTestGateway === true) |
There was a problem hiding this comment.
wallet payments for stripe are now live so we can probably remove the env var that toggles this feature
Suggested change
| convertedData.isDigitalWalletSupported = paymentProvider === 'worldpay' || | |
| (paymentProvider === 'sandbox' && process.env.ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT === 'true') || | |
| (paymentProvider === 'stripe' && process.env.ALLOW_ENABLING_DIGITAL_WALLETS_FOR_STRIPE_ACCOUNT === 'true') || | |
| (paymentProvider === 'stripe' && convertedData.isTestGateway === true) | |
| convertedData.isDigitalWalletSupported = paymentProvider === 'worldpay' || | |
| (paymentProvider === 'sandbox' && process.env.ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT === 'true') || | |
| paymentProvider === 'stripe' |
There was a problem hiding this comment.
might need to update some tests if taking this suggestion
|
This pull request has been superseded by pull request #4153 and can now be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Allow enabling Apple Pay and Google Pay for Sandbox gateway accounts
https://payments-platform.atlassian.net/browse/PP-11594
HOW