Check for duplicate id attributes in HTML
#5326
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quis
changed the title
id attributes in HTML
It’s invalid HTML to have multiple elements with the same `id` attribute. Plus it can cause trouble for Javascripts, and make anchor linking unpredictable.
quis
force-pushed
the
check-for-duplicate-ids
branch
from
e3c4941 to
b02ed8f
Compare
Where the table rows don’t need IDs, let’s not show them
quis
force-pushed
the
check-for-duplicate-ids
branch
from
b02ed8f to
1d71e7b
Compare
Functional tests still need these on the page: https://github.com/alphagov/notifications-functional-tests/blob/c9549ded6ab64ea61ba812a41cd7153541ceb784/tests/pages/pages.py#L917
quis
force-pushed
the
check-for-duplicate-ids
branch
from
1d71e7b to
a67425b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s invalid HTML to have multiple elements with the same
idattribute. Plus it can cause trouble for Javascripts, and make anchor linking unpredictable.