Remove old phonenumber validation #5294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparke
force-pushed
the
remove-old-phonenumber-validation
branch
from
07014d8 to
f096108
Compare
CrystalPea
reviewed
Nov 13, 2024
| @pytest.mark.parametrize( | ||
| "short_number, allowed", | ||
| ( | ||
| ("119", True), |
There was a problem hiding this comment.
I think the question should be - are there valid cases where service's contact number is a three-digit number?
It looks like it might be from this list? https://www.inyourarea.co.uk/news/10-three-digit-phone-numbers-and-what-theyre-for
For example Track and Trace had a 3-digit number, and there are some other ones.
I wonder how we previously validated this?
There was a problem hiding this comment.
This is an easy fix, and it's an exception to pure libphonenumber validation I'm okay with adding. We can either have an allow list, or just say "any 3 digit number that successfully parses to a "possible" UK number, we are just going to say is valid"
rparke
force-pushed
the
remove-old-phonenumber-validation
branch
2 times, most recently
from
bf3a83f to
6fa938c
Compare
rparke
commented
Nov 21, 2024
requirements.in
Outdated
| @@ -17,7 +17,7 @@ notifications-python-client==10.0.0 | |||
| fido2==1.1.3 | |||
|
|
|||
| # Run `make bump-utils` to update to the latest version | |||
| notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@f676a72f212ba9d8b1e8cc4dc5fd3211a2214960 | |||
| notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@de4d6573a0dfb5969156b5a7595f00c54f492cc0 | |||
There was a problem hiding this comment.
needs updating to semver'd tag once that has been merged
CrystalPea
approved these changes
Nov 22, 2024
rparke
force-pushed
the
remove-old-phonenumber-validation
branch
3 times, most recently
from
6f49f33 to
2e3ef21
Compare
CrystalPea
approved these changes
Nov 26, 2024
Phonenumbers automatically rejects both emergency and non-emergency (3 digit numbers). Need to consider whether we should test this here or re-write the code to reflect this change
returning a human readable phone number is a common use case for lots of the front end validation code. This introduces a utility function for this use
a consequence of using validation code based on libphonenumber is that a lot of numbers we previously thought were valid phone numbers that we could test against were in fact invalid. Keeping those numbers in our tests breaks because our libphonenumber based validation will throw unexpected exceptions for numbers that simply aren't possible or valid
…n_emergency 3 digit numbers and numbers with extentions The python port of libphonenumber is much stricter than our old bespoke validation code. As a result it does not accept phone numbers with extensions or phone numbers with 3 digits. This change incorporates the changes to utils that throw an appropriate error, and adds a crude method for handling numbers with extensions. The form will accept any number that returns a TOO_LONG error code, assuming it must be because of an extension (this shouldn't matter as we are not validating whether the phone number is real for notify to send sms notifications to. The service owner will be confident that they're providing the correct number for their service)
rparke
force-pushed
the
remove-old-phonenumber-validation
branch
from
2e3ef21 to
b951ef6
Compare
CrystalPea
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.