Configure hosts for application #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixed worked for a similar issue in Release (alphagov/release#1589) but did not work for a similar issue in Whitehall / Link Checker API: alphagov/whitehall#9542 Sharing just in case the latter trips you up like it did us. We have a card to revisit the latter fix. |
|
Ah, interesting! Thanks @ChrisBAshton. I note that if I try to deploy this to integration it appears to fail on the healthcheck, despite that being explicitly excluded from this. Is that similar to what happened on Whitehall? |
|
Latest PR @KludgeKML : alphagov/whitehall#9560 |
- the healthcheck endpoints are requested by IP, not domain, so we need to specifically exclude them from the protection. - internal API hostname is also necessary
KludgeKML
force-pushed
the
hostname-config-redux
branch
from
8a9499c to
8cd11fd
Compare
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
https://trello.com/c/6lU4aUGt/366-configure-hosts-for-application