Upgrade to Rails 7.1 #733
Merged
Upgrade to Rails 7.1 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
update-rails-7.1
branch
2 times, most recently
from
94874d2 to
0de67bb
Compare
jkempster34
approved these changes
Nov 1, 2023
| # require "syslog/logger" | ||
| # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name') | ||
|
|
||
| if ENV["RAILS_LOG_TO_STDOUT"].present? |
There was a problem hiding this comment.
Does it matter that logging to stdout is now the default instead of being controlled by this env variable?
There was a problem hiding this comment.
Good spot. I think I'll retain that environment variable to maintain the existing behaviour.
| @@ -28,7 +29,7 @@ | |||
| config.cache_store = :null_store | |||
|
|
|||
| # Raise exceptions instead of rendering exception templates. | |||
| config.action_dispatch.show_exceptions = false | |||
| config.action_dispatch.show_exceptions = :rescuable | |||
There was a problem hiding this comment.
Just read up on this, seems :rescuable is more appropriate than :none 👍
Rails 7.1.1 was updated through Dependabot without also running the Rails update task. This runs the task, updating the config where necessary.
This removes the defaults file, as we now switch to using Rails 7.1 defaults.
From Rails 7.2, the keyword `type` must be specified.
Prior to Rails 7.1, the default coder for `serialize` was YAML. Now it is `nil` and requires the user to make a choice. Therefore retaining YAML, to maintain backward compatibility.
This test started failing in Rails 7.1, as the default value of `config.action_dispatch.show_exceptions` was changed from `false` to `:rescuable`. This means we now render a nice 404 response rather than raising an exception, but need to update the test to match this. See https://mattbrictson.com/blog/rails-71-features#1-finally-we-can-write-proper-integration-tests-for-errors for some more information.
brucebolt
force-pushed
the
update-rails-7.1
branch
from
0de67bb to
b81f235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1.1 was updated in #725 without also running the Rails update task.
This runs the task, updating the config where necessary.
Trello card