Return 422 when request is unprocessable by Publishing API #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumknights
approved these changes
Nov 25, 2024
If the user provides data that is unprocessable by Publishing API (e.g. a base path with the incorrect content ID), we currently return a 500 error and log this to Sentry. This is not optimal behaviour as there is no application fault here, so no action can be taken by developers after seeing this logged in Sentry. Instead we should respond with a 422 and return the actual error to the user. Then they can correct the request they are making so it becomes valid.
brucebolt
force-pushed
the
return-422
branch
from
e81defe to
424a738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user provides data that is unprocessable by Publishing API (e.g. a base path with the incorrect content ID), we currently return a 500 error and log this to Sentry.
This is not optimal behaviour as there is no application fault here, so no action can be taken by developers after seeing this logged in Sentry.
Instead we should respond with a 422 and return the actual error to the user. Then they can correct the request they are making so it becomes valid.
Trello card