Swap-in live content-store-proxy in production #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third iteration of swapping-in the live content-store-proxy in production ( Trello card ).
Since rolling back the last iteration (#1300), we've made two major performance improvements (in content-store-proxy and content-store-postgresql-branch) and observed the staging setup handle a full govuk-mirror run without any of the
HTTP 499timeouts seen on previous runs, and without ever coming close to maxing-out its CPU allocation. As a result, we were able to return to fully-comparing 100% of responses on staging.For this production rollout, we'll stick with 10% initially and watch the response times, then increase the percentage once we're confident it's safe to do so. As before, we'll make sure to only merge this at a time when we're able to monitor it attentively and rollback promptly if there are any issues.