Fully-compare more content-store responses in staging #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-store, and 100% of the draft
theseanything
approved these changes
Oct 12, 2023
aldavidson
deleted the
compare-half-the-content-store-responses-in-staging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1307 we reduced the percentage of mongo/postgresql content-store responses that we fully compare, to reduce the CPU overhead introduced by the comparison.
Since then, we've found and fixed two major bottlenecks - one in the proxy code that did the comparison, and one in the postgres content-store itself - and have subsequently completed a load test in staging without any of the
HTTP 499timeouts that marked previous tests, and without even coming close to maxing out the recently-increased resource limitsSo, we're ready to increase the percentage of responses we compare again.
We're going for 50% on the live content-store, and 100% on the draft as that gets much less traffic. If it still performs well after this change, we can up it to 100% later