Make tweaks to frontend build #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns on vite-ruby's autobuild feature in development. This will run the vite build on page load if the source code has changed since the last build. This means developers won't have to run the frontend build manually when checking out a new branch.
This linting plugin didn't provide much value (users can run the frontend lint in a separate terminal) and it slowed down the vite build. This was especially annoying when starting bin/dev, since the main idea behind Vite is to have a fast development server. One consequence of removing this plugin is that vitest no longer automatically runs the linting task when running the tests. We were relying on this in the build_and_test github workflow, so this commit also readds the linting task to the github action.
These SVGs are used for the buttons in the markdown editor. The button toolbar is only shown as a JS enhancement, so it makes sense that these icons should be in the app/frontend/icons folder.
DavidBiddle
force-pushed
the
vite-build-improvements
branch
from
383d8f7 to
a888d7c
Compare
|
lfdebrux
reviewed
Oct 7, 2024
lfdebrux
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: None
Makes a few smallish changes to the frontend build:
See individual commit messages for details.
Things to consider when reviewing