Remove template local from skip_controller

app/controllers/pages/secondary_skip_controller.rb

@@ -4,33 +4,32 @@ class Pages::SecondarySkipController < PagesController
   before_action :ensure_secondary_skip_exists, only: %i[edit update delete destroy]
 
   def new
-    secondary_skip_input = Pages::SecondarySkipInput.new(form: current_form, page:)
-    render locals: { secondary_skip_input: }
+    @secondary_skip_input = Pages::SecondarySkipInput.new(form: current_form, page:)
   end
 
   def create
-    secondary_skip_input = Pages::SecondarySkipInput.new(secondary_skip_input_params)
+    @secondary_skip_input = Pages::SecondarySkipInput.new(secondary_skip_input_params)
 
-    if secondary_skip_input.submit
+    if @secondary_skip_input.submit
       redirect_to show_routes_path(form_id: current_form.id, page_id: page.id)
     else
-      render template: "pages/secondary_skip/new", locals: { secondary_skip_input: }, status: :unprocessable_entity
+      render template: "pages/secondary_skip/new", status: :unprocessable_entity
     end
   end
 
   def edit
-    secondary_skip_input = Pages::SecondarySkipInput.new(form: current_form, page:, record: secondary_skip_condition).assign_values
+    @secondary_skip_input = Pages::SecondarySkipInput.new(form: current_form, page:, record: secondary_skip_condition).assign_values
 
-    render template: "pages/secondary_skip/edit", locals: { secondary_skip_input: }
+    render template: "pages/secondary_skip/edit"
   end
 
   def update
-    secondary_skip_input = Pages::SecondarySkipInput.new(secondary_skip_input_params.merge(record: secondary_skip_condition))
+    @secondary_skip_input = Pages::SecondarySkipInput.new(secondary_skip_input_params.merge(record: secondary_skip_condition))
 
-    if secondary_skip_input.submit
+    if @secondary_skip_input.submit
       redirect_to show_routes_path(form_id: current_form.id, page_id: page.id)
     else
-      render template: "pages/secondary_skip/edit", locals: { secondary_skip_input: }, status: :unprocessable_entity
+      render template: "pages/secondary_skip/edit", status: :unprocessable_entity
     end
   end
 

app/views/pages/secondary_skip/edit.html.erb

@@ -1,9 +1,9 @@
 <% set_page_title(title_with_error_prefix(t('page_titles.new_secondary_skip', route_index: 2), false)) %>
-<% content_for :back_link, govuk_back_link_to(show_routes_path(form_id: secondary_skip_input.form.id, page_id: secondary_skip_input.page.id), t('secondary_skip.new.back', page_position: secondary_skip_input.page.position)) %>
+<% content_for :back_link, govuk_back_link_to(show_routes_path(form_id: @secondary_skip_input.form.id, page_id: @secondary_skip_input.page.id), t('secondary_skip.new.back', page_position: @secondary_skip_input.page.position)) %>
 
 <% content_for :heading do %>
   <h1 class="govuk-heading-l">
-    <span class="govuk-caption-l"><%= t("secondary_skip.new.caption", page_position: secondary_skip_input.page.position) %></span>
+    <span class="govuk-caption-l"><%= t("secondary_skip.new.caption", page_position: @secondary_skip_input.page.position) %></span>
     <%= t("page_titles.new_secondary_skip", route_index: 2) %>
     <%# TODO: route_index is hardcoded as 2 here because we know there are only two conditions. It will need to change in the future %>
   </h1>
@@ -12,8 +12,8 @@
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <%= render partial: 'form', locals: {
-      secondary_skip_input:,
-      submit_path: update_secondary_skip_path(form_id: secondary_skip_input.form.id, page_id: secondary_skip_input.page.id),
+      secondary_skip_input: @secondary_skip_input,
+      submit_path: update_secondary_skip_path(form_id: @secondary_skip_input.form.id, page_id: @secondary_skip_input.page.id),
     } %>
   </div>
 </div>

app/views/pages/secondary_skip/new.html.erb

@@ -1,9 +1,9 @@
 <% set_page_title(title_with_error_prefix(t('page_titles.new_secondary_skip', route_index: 2), false)) %>
-<% content_for :back_link, govuk_back_link_to(show_routes_path(form_id: secondary_skip_input.form.id, page_id: secondary_skip_input.page.id), t('secondary_skip.new.back', page_position: secondary_skip_input.page.position)) %>
+<% content_for :back_link, govuk_back_link_to(show_routes_path(form_id: @secondary_skip_input.form.id, page_id: @secondary_skip_input.page.id), t('secondary_skip.new.back', page_position: @secondary_skip_input.page.position)) %>
 
 <% content_for :heading do %>
   <h1 class="govuk-heading-l">
-    <span class="govuk-caption-l"><%= t("secondary_skip.new.caption", page_position: secondary_skip_input.page.position) %></span>
+    <span class="govuk-caption-l"><%= t("secondary_skip.new.caption", page_position: @secondary_skip_input.page.position) %></span>
     <%= t("page_titles.new_secondary_skip", route_index: 2) %>
     <%# TODO: route_index is hardcoded as 2 here because we know there are only two conditions. It will need to change in the future %>
   </h1>
@@ -12,8 +12,8 @@
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <%= render partial: 'form', locals: {
-      secondary_skip_input:,
-      submit_path: create_secondary_skip_path(form_id: secondary_skip_input.form.id, page_id: secondary_skip_input.page.id),
+      secondary_skip_input: @secondary_skip_input,
+      submit_path: create_secondary_skip_path(form_id: @secondary_skip_input.form.id, page_id: @secondary_skip_input.page.id),
     } %>
   </div>
 </div>

spec/views/pages/secondary_skip/new.html.erb_spec.rb

@@ -22,7 +22,8 @@
   let(:secondary_skip_input) { Pages::SecondarySkipInput.new(form:, page:) }
 
   before do
-    render template: "pages/secondary_skip/new", locals: { secondary_skip_input: }
+    assign(:secondary_skip_input, secondary_skip_input)
+    render template: "pages/secondary_skip/new"
   end
 
   it "has the correct title" do