Remove links field #645
Merged
Remove links field #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one step towards solving #632 and avoids unnecessary confusion over their being two fields for accessing the links. There are only 310 content items left which have something in the `links`: ```rb irb(main):005:0> ContentItem.where(:links.nin => [{}, nil]).count => 310 ``` I don't think we need to write a migration to remove this field because as new content is presented to the content store, it'll get overwritten anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step towards solving #632 and avoids unnecessary confusion over their being two fields for accessing the links.
There are only 310 content items left which have something in the
links:I don't think we need to write a migration to remove this field because as new content is presented to the content store, it'll get overwritten anyway.