Remove placeholder logic #1152
Merged
Remove placeholder logic #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placeholder schemas were added to hold documents that were rendered by Whitehall and not yet ready to be presented to end users. This added some complexity to Publishing API and Content Store, as these routes did not need to be registered with Router. Therefore removing this logic now all rendering has been migrated out of Whitehall.
brucebolt
force-pushed
the
remove-placeholder-logic
branch
from
7ba32bd to
bbe2fda
Compare
aldavidson
added a commit
that referenced
this pull request
Dec 22, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
pushed a commit
that referenced
this pull request
Dec 27, 2023
brucebolt
added a commit
that referenced
this pull request
Mar 12, 2024
Whitehall Frontend was switched off in 2023. However, as a result of a bug where some documents were missed when they were bulk republished, a small number (approximately 65) of documents remained in the Content Store database with a rendering app of `whitehall-frontend` and a schema name of `placeholder`. The logic to deal with placeholders was removed in #1152, therefore the routes were never registered for these content items (and never will be, as Content Store assumes they have already been rendered). Since the public versions of these page already return a 404 or 500 error (or in some cases, have a redirect implemented directly in Router), it is safe to remove them and republish the affected pages from Whitehall to correctly register the routes and make these pages available again to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder schemas were added to hold documents that were rendered by Whitehall and not yet ready to be presented to end users.
This added some complexity to Publishing API and Content Store, as these routes did not need to be registered with Router.
Therefore removing this logic now all rendering has been migrated out of Whitehall.
Depends on alphagov/publishing-api#2504.
Trello card
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.