Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade app to Rails 7.2 #2187

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Upgrade app to Rails 7.2 #2187

merged 5 commits into from
Dec 2, 2024

Conversation

MuriloDalRi
Copy link
Contributor

@MuriloDalRi MuriloDalRi commented Nov 21, 2024 •
edited
Loading

Upgrades Rails from 7.1 to 7.2

alphagov/govuk-infrastructure#1444

@MuriloDalRi MuriloDalRi marked this pull request as draft November 21, 2024 12:40
@MuriloDalRi MuriloDalRi force-pushed the rails-7-2 branch 2 times, most recently from 3152015 to f9499e9 Compare November 25, 2024 11:47
@MuriloDalRi MuriloDalRi marked this pull request as ready for review November 25, 2024 11:50
@MuriloDalRi MuriloDalRi requested a review from a team November 25, 2024 14:02
@theseanything
Copy link
Contributor

Do we need all the HTML error pages - as this app only serves a JSON API?

@MuriloDalRi
Copy link
Contributor Author

Do we need all the HTML error pages - as this app only serves a JSON API?

Probably not, but I just assumed since it already had some error pages that there was no harm in updating or adding a new one. Do you want me to remove them all?

@theseanything
Copy link
Contributor

theseanything commented Nov 25, 2024 •
edited
Loading

Do we need all the HTML error pages - as this app only serves a JSON API?

Probably not, but I just assumed since it already had some error pages that there was no harm in updating or adding a new one. Do you want me to remove them all?

Yah - best not to add unused code to the repo

@MuriloDalRi MuriloDalRi force-pushed the rails-7-2 branch 2 times, most recently from 7704278 to 1df0323 Compare November 28, 2024 10:49
@MuriloDalRi
Copy link
Contributor Author

Do we need all the HTML error pages - as this app only serves a JSON API?

Probably not, but I just assumed since it already had some error pages that there was no harm in updating or adding a new one. Do you want me to remove them all?

Yah - best not to add unused code to the repo

I've removed all of that now.

theseanything
theseanything approved these changes Dec 2, 2024
View reviewed changes
bin/setup Outdated
APP_ROOT = File.expand_path("..", __dir__)
APP_NAME = "content-performance-manager"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APP_NAME = "content-performance-manager"
APP_NAME = "content-data-api"

@dj-maisy dj-maisy mentioned this pull request Dec 2, 2024
Closed
@MuriloDalRi MuriloDalRi enabled auto-merge December 2, 2024 14:49
@MuriloDalRi MuriloDalRi merged commit c5e01d0 into main Dec 2, 2024
8 checks passed
@MuriloDalRi MuriloDalRi deleted the rails-7-2 branch December 2, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseanything theseanything theseanything approved these changes

Assignees

@MuriloDalRi MuriloDalRi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuriloDalRi @theseanything