Remove rake task that relies on CSV input #1529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rake tasks that rely on CSV input are a throwback to the old Puppet infrastructure of GOV.UK, where each app was running on dedicated VMs, meaning there was always a fairly stable/reliable file system to which we could upload said CSV and then run the rake task against it via Jenkins. Kubernetes pods, in contrast, are ephemeral in nature, so any uploaded CSVs could be lost at any time. We should therefore migrate CSV-based rake tasks into the UI of the respective publishing app, or remove it if it is no longer needed.
This particular rake task was added 11 years ago in commit d94d415. It was probably used to do a one-off import of data, and I'm not aware of us having been asked to run it again since, as publishers are able to add contacts manually through the UI. It should therefore be safe to delete.
Trello: https://trello.com/c/yi1ExGvz/3179-audit-rake-tasks-that-rely-on-scp-push