Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rake task that relies on CSV input #1529

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

ChrisBAshton
Copy link
Contributor

Rake tasks that rely on CSV input are a throwback to the old Puppet infrastructure of GOV.UK, where each app was running on dedicated VMs, meaning there was always a fairly stable/reliable file system to which we could upload said CSV and then run the rake task against it via Jenkins. Kubernetes pods, in contrast, are ephemeral in nature, so any uploaded CSVs could be lost at any time. We should therefore migrate CSV-based rake tasks into the UI of the respective publishing app, or remove it if it is no longer needed.

This particular rake task was added 11 years ago in commit d94d415. It was probably used to do a one-off import of data, and I'm not aware of us having been asked to run it again since, as publishers are able to add contacts manually through the UI. It should therefore be safe to delete.

Trello: https://trello.com/c/yi1ExGvz/3179-audit-rake-tasks-that-rely-on-scp-push

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Rake tasks that rely on CSV input are a throwback to the old
Puppet infrastructure of GOV.UK, where each app was running on
dedicated VMs, meaning there was always a fairly stable/reliable
file system to which we could upload said CSV and then run the
rake task against it via Jenkins. Kubernetes pods, in contrast,
are ephemeral in nature, so any uploaded CSVs could be lost at
any time. We should therefore migrate CSV-based rake tasks into
the UI of the respective publishing app, or remove it if it is no
longer needed.

This particular rake task was added 11 years ago in commit
d94d415. It was probably used to
do a one-off import of data, and I'm not aware of us having been
asked to run it again since, as publishers are able to add contacts
manually through the UI. It should therefore be safe to delete.

Trello: https://trello.com/c/yi1ExGvz/3179-audit-rake-tasks-that-rely-on-scp-push
@ChrisBAshton ChrisBAshton merged commit 47f26cd into main Nov 20, 2024
10 checks passed
@ChrisBAshton ChrisBAshton deleted the remove-csv-rake-task branch November 20, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants