Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove document navigation list component #3894

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Dec 9, 2024

What

  • Remove the document-navigation-list app component
  • Create a new partial to render "featured links", this partial makes use of the the list component from the govuk_publishing_components gem, this partial is mostly based off the previous document-navigation-list template
    • The see_more option in the document-navigation-list component has not been copied to the new "featured_links" partial as it was not used in any of the views templates updated
  • Replace document-list-navigation app level component with the new featured links partial

Why

The document-navigation-list component has some custom styling applied which is not aligned with the design system.

If the list styles are updated in the future, it is unlikely that we would benefit from there where this component is used.

Trello card

Visual changes

The featured links now makes use of the extra_spacing option from the list, when set to true it will add the "govuk-list--spaced" class from the design system, this sets the margin bottom to 15px for each list item, this was previously 10px.

Before After
news-before news-after
Before After
courts-before courts-after
Before After
corp-job-info-before corp-job-info-after

Replace the `document_navigation_list` component with the newly created `featured_links` partial
Featured links are now displayed using the `list` component from the govuk-publishing-components gem
@govuk-ci govuk-ci temporarily deployed to collections-pr-3894 December 9, 2024 09:33 Inactive
@MartinJJones MartinJJones marked this pull request as ready for review December 9, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants