Prepare for upgrade to rails 7.1 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid the following deprecation warning when upgrading to Rails 7.1.0: > DEPRECATION WARNING: Passing the class as positional argument is > deprecated and will be removed in Rails 7.2.
Rails 7 changed the default digest class for the key generator from SHA1 to SHA256[1]. The code removed in this commit was added on 15 Mar 2022 in 05a41d8. The intention was to allow any cookies encrypted using the SHA1 key generator to be read and re-encrypted using SHA256. I can't see any record of us manually setting encrypted cookies using `cookies.encrypted`[2] so I think this would have only applied to our sessions which are stored using the (encrypted) CookieStore[3]. Given that this rotator was added 17 months ago I think it's safe to remove it (i.e. I would expect all existing sessions from 17 months ago to have been rotated). Note that although we don't make any calls to `session` in authenticating-proxy, there are calls to `session` in the gds-sso Gem that's included in this app: - GDS::SSO::FailureApp#store_location![4] - AuthenticationsController#callback[5] - lib/gds-sso/warden_config.rb[6] [1]: https://guides.rubyonrails.org/v7.0/upgrading_ruby_on_rails.html#key-generator-digest-class-changing-to-use-sha256 [2]: https://api.rubyonrails.org/v7.1.1/classes/ActionDispatch/Cookies.html [3]: https://api.rubyonrails.org/classes/ActionDispatch/Session/CookieStore.html [4]: https://github.com/alphagov/gds-sso/blob/v18.1.0/lib/gds-sso/failure_app.rb#L48 [5]: https://github.com/alphagov/gds-sso/blob/v18.1.0/app/controllers/authentications_controller.rb#L8 [6]: https://github.com/alphagov/gds-sso/blob/v18.1.0/lib/gds-sso/warden_config.rb#L15
|
Thanks @floehopper! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes preemptively avoid two deprecation warnings that appear when we upgrade to Rails 7.1:
and