-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-211: CI build checks for the prover guest code #512
base: main
Are you sure you want to change the base?
Conversation
ab921ad
to
ec76424
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 56.58% 56.55% -0.03%
==========================================
Files 275 275
Lines 29192 29192
==========================================
- Hits 16517 16510 -7
- Misses 12675 12682 +7 |
8b523a5
to
08ea646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add build check for the prover-client binary here ?
I think in normal CI build it will be also skipped
strata/bin/prover-client/Cargo.toml
Lines 6 to 9 in 08ea646
[[bin]] | |
name = "strata-prover-client" | |
path = "src/main.rs" | |
required-features = ["prover"] |
08ea646
to
8ebb175
Compare
@MdTeach Thanks a lot!!! You are completely right. I missed one directory, didn't realize that there's no Trying to restrict it. |
Why were all those files deleted? |
@delbonis to not bloat the actions tab on the repository, because I experiment a lot and run CI on this branch frequently. |
Description
Type of Change
Notes to Reviewers
Checklist
Related Issues