Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-211: CI build checks for the prover guest code #512

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

evgenyzdanovich
Copy link
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich force-pushed the str-211-prover-ci branch 4 times, most recently from ab921ad to ec76424 Compare December 2, 2024 13:11
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.55%. Comparing base (f07bab7) to head (ec76424).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   56.58%   56.55%   -0.03%     
==========================================
  Files         275      275              
  Lines       29192    29192              
==========================================
- Hits        16517    16510       -7     
- Misses      12675    12682       +7     

see 5 files with indirect coverage changes

@evgenyzdanovich evgenyzdanovich force-pushed the str-211-prover-ci branch 8 times, most recently from 8b523a5 to 08ea646 Compare December 3, 2024 01:23
Copy link
Contributor

@MdTeach MdTeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add build check for the prover-client binary here ?
I think in normal CI build it will be also skipped

[[bin]]
name = "strata-prover-client"
path = "src/main.rs"
required-features = ["prover"]

@evgenyzdanovich
Copy link
Contributor Author

Should we also add build check for the prover-client binary here ? I think in normal CI build it will be also skipped

[[bin]]
name = "strata-prover-client"
path = "src/main.rs"
required-features = ["prover"]

@MdTeach Thanks a lot!!! You are completely right. I missed one directory, didn't realize that there's no cargo.toml under provers/ and it was building the whole thing (including reth and all other binaries).

Trying to restrict it.

@delbonis
Copy link
Contributor

delbonis commented Dec 3, 2024

Why were all those files deleted?

@evgenyzdanovich
Copy link
Contributor Author

@delbonis to not bloat the actions tab on the repository, because I experiment a lot and run CI on this branch frequently.
I'll add it back definitely once the PR is ready for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants